Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for invalid land categories in CRTM #810

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

EricJames-NOAA
Copy link
Contributor

Collaborators at Wisconsin noted that two land surface types were being assigned as INVALID_LAND for CRTM. This PR restores the appropriate land surface type, getting rid of NaNs in the simulated brightness temperature output.

The code was tested for the RRFS_CONUS_3km system on Jet, and leads to minor expected differences in the simulated brightness temperatures (fewer undefined values).

@WenMeng-NOAA WenMeng-NOAA linked an issue Oct 26, 2023 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the bug Something isn't working label Oct 26, 2023
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Can you sync your branch?

@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels Oct 27, 2023
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2. There will be baseline updates for fv3r, rap and hrrr with this PR.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. This PR is a bug fix. There will be no field value change in grib2 files. I would think the baseline changes from rap/hrrr/fv3r are from grib2 metadata. But you will notice the following error message have disappeared in runtime logs.

 CRTM_LandSurface_IsValid(INFORMATION) : Invalid Land Surface type
 CRTM_Forward(FAILURE) : Input data check failed for profile #1
 CRTM_Forward(FAILURE) : 1 profiles failed
 ***ERROR*** during crtm_forward call       3

My UPP RTs on Hera are at /scratch1/NCEPDEV/stmp2/Wen.Meng:

-rw-r--r-- 1 Wen.Meng stmp    75 Oct 27 17:34 rap_2020072316/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Oct 27 17:34 hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Oct 27 17:34 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Oct 27 17:35 hrrr_2020060118/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp 14460 Oct 27 17:37 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14460 Oct 27 17:37 fv3r_2023062800/NATLEV10.tm00.diff

@FernandoAndrade-NOAA
Copy link
Collaborator

Apologies for the delay in test results, Jenkins CI had a GitHub credentials issue, but it seems to be resolved and is properly building for RTs now. I'll post results when available.

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA Hera and Orion UPP RT results are consistent with yours.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Oct 28, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit baf99e5 into NOAA-EMC:develop Oct 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. bug Something isn't working Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with land surface type
3 participants