-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for invalid land categories in CRTM #810
Conversation
@EricJames-NOAA Can you sync your branch? |
The UPP RTs were completed on WCOSS2. There will be baseline updates for fv3r, rap and hrrr with this PR. |
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. This PR is a bug fix. There will be no field value change in grib2 files. I would think the baseline changes from rap/hrrr/fv3r are from grib2 metadata. But you will notice the following error message have disappeared in runtime logs.
My UPP RTs on Hera are at /scratch1/NCEPDEV/stmp2/Wen.Meng:
|
Apologies for the delay in test results, Jenkins CI had a GitHub credentials issue, but it seems to be resolved and is properly building for RTs now. I'll post results when available. |
@WenMeng-NOAA Hera and Orion UPP RT results are consistent with yours. |
This PR is ready for merging. |
Collaborators at Wisconsin noted that two land surface types were being assigned as INVALID_LAND for CRTM. This PR restores the appropriate land surface type, getting rid of NaNs in the simulated brightness temperature output.
The code was tested for the RRFS_CONUS_3km system on Jet, and leads to minor expected differences in the simulated brightness temperatures (fewer undefined values).