Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing blowing snow impact on visibility #823

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Introducing blowing snow impact on visibility #823

merged 4 commits into from
Nov 30, 2023

Conversation

EricJames-NOAA
Copy link
Contributor

This PR adds the blowing snow effect within the GSL surface visibility diagnostic. The code has been running in parallel in the GSL RRFS-B over the past ~8 months, with side-by-side visibility output with and without the impact of blowing snow, allowing evaluation for some cases.

The code was developed by Tim Corrie of the University of Wyoming as part of his MS project.

@WenMeng-NOAA WenMeng-NOAA linked an issue Nov 22, 2023 that may be closed by this pull request
Add impact of blowing snow in GSL visibility diagnostic #819
Closed
@WenMeng-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA Can you help us to fix this intel build failure in CI? Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@JongilHan66 Please review visibility calculation enhancement in this PR and let me know your opinion on whether this change should be implemented in GFS V17.

@JongilHan66
Copy link

@JongilHan66 Please review visibility calculation enhancement in this PR and let me know your opinion on whether this change should be implemented in GFS V17.

I am ok to implement it in gfsv17. Please also check it with Fanglin.

@WenMeng-NOAA
Copy link
Collaborator

@yangfanglin Do you have comments on this enhancement implemented in GFS V17?

@yangfanglin
Copy link

@yangfanglin Do you have comments on this enhancement implemented in GFS V17?

I am OK with this enhancement. @EricJames-NOAA Can you attach a copy of Tim Corrie's presentation and your evaluation ppt to this PR for us to understand what the expected impact is ?

@AlexanderRichert-NOAA
Copy link
Contributor

For the Intel failure, the fix is to specify versions for the compilers when doing the installation with apt, i.e., 'intel-oneapi-compiler-fortran-2023.2.1 intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic-2023.2.1'.

@WenMeng-NOAA
Copy link
Collaborator

For the Intel failure, the fix is to specify versions for the compilers when doing the installation with apt, i.e., 'intel-oneapi-compiler-fortran-2023.2.1 intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic-2023.2.1'.

@AlexanderRichert-NOAA My understand is the changes would in intel.yml?

@AlexanderRichert-NOAA
Copy link
Contributor

@WenMeng-NOAA yes exactly

@EricJames-NOAA
Copy link
Contributor Author

Here are some slides comparing the visibility diagnostic with and without the effect of blowing snow for a recent case in North Dakota.

We have some other evaluations, but they are mostly qualitative comparisons.

ND_blsn.pptx

@yangfanglin
Copy link

Thanks, Eric. Looks like the impact is significant.

@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels Nov 28, 2023
@WenMeng-NOAA
Copy link
Collaborator

The UPP RT was conducted at /u/wen.meng/ptmp on Hera. The changes are

wen.meng@clogin03 ptmp$ ls -ltr */*diff
-rw-r--r-- 1 wen.meng emc   132 Nov 28 15:10 rap_2020072316/WRFPRS.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    60 Nov 28 15:10 post_nmmb_meso_2014120818_Grib2/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 wen.meng emc    61 Nov 28 15:10 rap_2020072316/WRFNAT.GrbF16.diff
-rw-r--r-- 1 wen.meng emc   132 Nov 28 15:11 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    56 Nov 28 15:11 hrrr_2020060118/WRFTWO.GrbF04.diff
-rw-r--r-- 1 wen.meng emc    61 Nov 28 15:12 rap_2020072316_pe_test/WRFNAT.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    60 Nov 28 15:12 post_nmmb_meso_2014120818_Grib2_pe_test/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 wen.meng emc  1831 Nov 28 15:12 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc 14659 Nov 28 15:12 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc  2410 Nov 28 15:14 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc 14460 Nov 28 15:14 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc    56 Nov 28 15:14 hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
-rw-r--r-- 1 wen.meng emc  1831 Nov 28 15:18 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc 14659 Nov 28 15:19 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc  2410 Nov 28 15:21 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc 14460 Nov 28 15:21 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc  3495 Nov 28 15:23 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 wen.meng emc  3495 Nov 28 15:37 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

The main change is in visibility field (VIS), such as:

16:6358388:VIS:surface:rpn_corr=0.999995:rpn_rms=29.8503 in the test rap_2020072316

@FernandoAndrade-NOAA You may start the UPP RT on Hera and Orion.

@FernandoAndrade-NOAA
Copy link
Collaborator

The UPP RT was conducted at /u/wen.meng/ptmp on Hera. The changes are

wen.meng@clogin03 ptmp$ ls -ltr */*diff
-rw-r--r-- 1 wen.meng emc   132 Nov 28 15:10 rap_2020072316/WRFPRS.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    60 Nov 28 15:10 post_nmmb_meso_2014120818_Grib2/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 wen.meng emc    61 Nov 28 15:10 rap_2020072316/WRFNAT.GrbF16.diff
-rw-r--r-- 1 wen.meng emc   132 Nov 28 15:11 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    56 Nov 28 15:11 hrrr_2020060118/WRFTWO.GrbF04.diff
-rw-r--r-- 1 wen.meng emc    61 Nov 28 15:12 rap_2020072316_pe_test/WRFNAT.GrbF16.diff
-rw-r--r-- 1 wen.meng emc    60 Nov 28 15:12 post_nmmb_meso_2014120818_Grib2_pe_test/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 wen.meng emc  1831 Nov 28 15:12 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc 14659 Nov 28 15:12 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc  2410 Nov 28 15:14 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc 14460 Nov 28 15:14 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc    56 Nov 28 15:14 hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
-rw-r--r-- 1 wen.meng emc  1831 Nov 28 15:18 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc 14659 Nov 28 15:19 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc  2410 Nov 28 15:21 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 wen.meng emc 14460 Nov 28 15:21 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 wen.meng emc  3495 Nov 28 15:23 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 wen.meng emc  3495 Nov 28 15:37 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

The main change is in visibility field (VIS), such as:

16:6358388:VIS:surface:rpn_corr=0.999995:rpn_rms=29.8503 in the test rap_2020072316

@FernandoAndrade-NOAA You may start the UPP RT on Hera and Orion.

Most of my Hera RTs seem to match size and changes in VIS to your tests, however I'm seeing a size discrepancy with the gfs test. The changes seem expected however the diff is 3444 unlike your 3495. I'm not able to look at your test directory given, if you'd like to compare to mine it's in /scratch2/NAGAPE/epic/Fernando.Andrade-maldonado/regression-tests/upp/823/UPP/ci/rundir/upp-HERA
Orion and Hercules are still running RTs at this time. Thank you

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA Orion seems to match your results on Hera. Hercules had a fatal error occur within 3drtma and I did not see the expected VIS change within NATLEV:

+ /home/wmeng/bin/cmp_grib2_grib2_new /work/noaa/epic/UPP/data_out/3drtma/NATLEV00.tm00.HERCULES NATLEV00.tm00

*** FATAL ERROR: rd_grib2_msg_seq_file for /work/noaa/epic/UPP/data_out/3drtma/NATLEV00.tm00.HERCULES, missing end section ('7777') ***

Both hera and hercules are running into errors with gfs:

+ /home/wmeng/bin/cmp_grib2_grib2_new /work/noaa/epic/UPP/data_out/gfs/gfs.t00z.master.grb2f006.HERCULES gfs.t00z.master.grb2f006

*** FATAL ERROR: bad complex packing: n points 308226 ***

It looks like there may be an issue finding pgbfile, pgbfile.grib2, fluxfile, and goesfile:

/work2/noaa/epic/nandoam/regression-testing/upp/hercules/823/UPP/ci/..//ush/gfs_nceppost.sh[404]: pgbfile: not found

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA

Most of my Hera RTs seem to match size and changes in VIS to your tests, however I'm seeing a size discrepancy with the gfs test. The changes seem expected however the diff is 3444 unlike your 3495. I'm not able to look at your test directory given, if you'd like to compare to mine it's in /scratch2/NAGAPE/epic/Fernando.Andrade-maldonado/regression-tests/upp/823/UPP/ci/rundir/upp-HERA

I don't see any discrepancies between your testing at /scratch2/NAGAPE/epic/Fernando.Andrade-maldonado/regression-tests/upp/823/UPP/ci/rundir/upp-HERA and my testing at /scratch1/NCEPDEV/stmp2/Wen.Meng on Hera. I would think the UPP RT on Hera is fine.

@FernandoAndrade-NOAA
Copy link
Collaborator

As discussed in the weekly CM meeting, we will be proceeding with the merge process as Orion and Hera RT results were as expected. Two separate issues will be created for the Hera missing files error and the Hercules fatal errors. Awaiting WRFPOST.f changelog comment before approval.

@EricJames-NOAA
Copy link
Contributor Author

As discussed in the weekly CM meeting, we will be proceeding with the merge process as Orion and Hera RT results were as expected. Two separate issues will be created for the Hera missing files error and the Hercules fatal errors. Awaiting WRFPOST.f changelog comment before approval.

Thanks for the reminder! I added a change log entry in WRFPOST.f

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2, Hera and Orion. There will be baseline recreation for gfs, fv3r, 3drtma, rap, hrrr and nmmb with this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit b469e27 into NOAA-EMC:develop Nov 30, 2023
3 of 4 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Nov 30, 2023
Closed
@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. GFSV17 labels Nov 30, 2023
souopgui added a commit to souopgui-redline/UPP that referenced this pull request Nov 30, 2023
@souopgui
Merge pull request #1 from NOAA-EMC/develop
c8ab09f 
Introducing blowing snow impact on visibility (NOAA-EMC#823)
souopgui added a commit to souopgui-redline/UPP that referenced this pull request Nov 30, 2023
@souopgui
Merge pull request #2 from NOAA-EMC/develop
aca5dcf 
Introducing blowing snow impact on visibility (NOAA-EMC#823)
@FernandoAndrade-NOAA FernandoAndrade-NOAA mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. GFSV17 Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add impact of blowing snow in GSL visibility diagnostic
6 participants
@EricJames-NOAA @WenMeng-NOAA @JongilHan66 @yangfanglin @AlexanderRichert-NOAA @FernandoAndrade-NOAA