Update UPP modulefile on S4 with spack-stack 1.5.0

[souopgui]

• Rename s4 modulefiles to s4.lua on S4
• Update s4.lua with spack-stack on S4

[FernandoAndrade-NOAA]

Hello @souopgui, with the switch to spack-stack 1.5.0, UPP has restructured its .lua module files to resemble the ufs weather model more closely. The upp_common.lua file should now include most of those load commands and versions within your S4 .lua, meaning you can remove the duplicate loads and instead load("upp_common") similar to the hera, hercules, and orion modulefiles. Typically only the stack-intel, stack-intel-oneapi-mpi, and cmake loads remain within the .lua modulefiles.

This would make it a bit easier to manage and read, if you could introduce those changes into your s4.lua. Thank you.

[souopgui]

Hello @souopgui, with the switch to spack-stack 1.5.0, UPP has restructured its .lua module files to resemble the ufs weather model more closely. The upp_common.lua file should now include most of those load commands and versions within your S4 .lua, meaning you can remove the duplicate loads and instead load("upp_common") similar to the hera, hercules, and orion modulefiles. Typically only the stack-intel, stack-intel-oneapi-mpi, and cmake loads remain within the .lua modulefiles.

This would make it a bit easier to manage and read, if you could introduce those changes into your s4.lua. Thank you.

Done.

[WenMeng-NOAA]

@souopgui Can you open an UPP issue to link this PR?

[WenMeng-NOAA]

The build test on WCOSS2 was completed.

[FernandoAndrade-NOAA]

The build test on WCOSS2 was completed.

There was a delay due to an unexpected issue with cloning, running RTs on Hera and Orion now.

[WenMeng-NOAA]

The build test on WCOSS2 was completed.

There was a delay due to an unexpected issue with cloning, running RTs on Hera and Orion now.

@FernandoAndrade-NOAA No need for running the whole UPP RT since the update of the modulefile on s4 should have no impact on the UPP build on WCOSS2, Hera and Orion. You might have the same build test either Hera and Orion as mine on WCOSS2:

cd UPP/tests
./compile_upp.sh

[FernandoAndrade-NOAA]

The build test on WCOSS2 was completed.

There was a delay due to an unexpected issue with cloning, running RTs on Hera and Orion now.

@FernandoAndrade-NOAA No need for running the whole UPP RT since the update of the modulefile on s4 should have no impact on the UPP build on WCOSS2, Hera and Orion. You might have the same build test either Hera and Orion as mine on WCOSS2:

cd UPP/tests
./compile_upp.sh

I was unsure if that was sufficient, thanks for the heads up! In that case hera, hercules and orion built successfully

[WenMeng-NOAA]

This PR is ready for merging.