Fifth reconciliation PR from production/RRFS.v1 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to address netcdf write hangs within RRFS system
…cycle==1 for retrospectives (NOT operational!) (NOAA-EMC#812) * Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!) * Move ebu_smoke outside of extended_sd_diag IF block in diagnostics * Update ccpp/physics to relevant commmit, revert .gitmodules back to original state
…ton/RRFS.v1 were already in develop
14 tasks
jkbk2004
approved these changes
Dec 16, 2024
|
@jkbk2004 This is ready to review/merge. |
DusanJovic-NOAA
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same as #812, but targeting the develop branch.
This is @jordanschnell's work and his description is as follows:
For ebb_dcycle==1 (retrospective fire emissions), the 3-d emissions were incorrectly assgined assigned at all levels using the surface data.
Issue(s) addressed
fixes Issue ufs-community/ccpp-physics#188
Testing
This was tested using UWM RTs on Hera. See ufs-community/ufs-weather-model#2485 for results.
Dependencies
ufs-community/ccpp-physics#231
Requirements before merging