Remove -DUSE_COND and -DMOIST_CAPPA for hydrostatic runs

[XiaqiongZhou-NOAA]

Description

The compiling flags -DUSE_COND and -DMOIST_CAPPA are removed for hydrostatic runs.

Fixes # (issue)

How Has This Been Tested?

It was tested on Hera with intel and gnu. A regression test with hydrostatic options is added in UFS.
Related PRs:

NOAA-EMC/fv3atm#828
ufs-community/ufs-weather-model#2255

Checklist:

Please check all whether they apply or not

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[lharris4]

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

[XiaqiongZhou-NOAA]

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

yes.

[yangfanglin]

@lharris4 Lucas, when the change from a compile-time option to a runtime option be ready ? We'd like to start using the hydro option for SFS development as soon as possible. Can Kate still commit this minor change while your team works on the namelist option ?

[lharris4]

Hi, Fanglin. We haven't started working on this yet as we have been busy with other tasks. Indeed for now Kate's revision is the right solution. Thanks Lucas

…

On Fri, Apr 26, 2024 at 10:31 AM Fanglin Yang ***@***.***> wrote: @lharris4 <https://github.com/lharris4> Lucas, when the change from a compile-time option to a runtime option be ready ? We'd like to start using the hydro option for SFS development as soon as possible. Can Kate still commit this minor change while your team works on the namelist option ? — Reply to this email directly, view it on GitHub <#337 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVH4YYDESOOERSBLWVTY7JQM7AVCNFSM6AAAAABG24FW4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGUYTENRXGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[junwang-noaa]

@XiaqiongZhou-NOAA how urgent do you need to commit the changes in? We need to coordinate with EPIC to get this committed and updated in UFS weather model.

[XiaqiongZhou-NOAA]

@XiaqiongZhou-NOAA how urgent do you need to commit the changes in? We need to coordinate with EPIC to get this committed and updated in UFS weather model.

@junwang-noaa I consider it as "Normal". I also created related PRs in UFS. This change will not impact other runs, only change the result when -DHYDRO=ON.

[zach1221]

Regression Testing is finished on WM PR #2255. @bensonr can you please merge this cubed sphere PR?