+Add optional unscale argument to MOM_write_field #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional unscale argument to 10 routines under the overloaded MOM_write_field interface, mirroring the recent additions of unscale arguments to the various chksum routines. These new unscale arguments are synonymous with the existing optional scale arguments to these routines, and if both are provided, the new unscale arguments take precedence. A total of 26 MOM_write_field calls in save_restart, write_depth_list, write_Hybgen_coord_file, write_vertgrid_file and write_ocean_geometry_file were modified to replace a scale argument with the new unscale argument. All answers are bitwise identical, but there are new optional arguments to 10 publicly visible routines.
Hallberg-NOAA
changed the title
theresa-morrison
approved these changes
Jun 24, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24056 ✔️ |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional
unscaleargument to 10 routines under the overloadedMOM_write_field()interface, mirroring the recent additions ofunscalearguments to the variouschksumroutines. These newunscalearguments are synonymous with the existing optionalscalearguments to these routines, and if both are provided, the newunscalearguments take precedence.A total of 26
MOM_write_field()calls insave_restart(),write_depth_list(),write_Hybgen_coord_file(),write_vertgrid_file()andwrite_ocean_geometry_file()were modified to replace ascaleargument with the newunscaleargument.All answers are bitwise identical, but there are new optional arguments to 10 publicly visible routines.