+Renamed myStats scale argument to unscale #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-morrison
approved these changes
Jun 24, 2024
marshallward
approved these changes
Jul 9, 2024
Renamed the optional scale argument to myStats to unscale, mirroring the recent additions of unscale arguments to the various chksum routines. This included changes to 6 calls to myStats in the two horiz_interp_and_extrap_tracer routines. Although myStats is public, it really is only used in MOM_horizontal_regridding in the main version of MOM6, apart from a single call in MOM_initialize_tracer_from_Z that does not use the optional unscale argument, so rather than adding a second optional argument, this case seemed to be safe enough to rename the argument in place. If there were any unanticipated problems with this argument name change, they would be manifest in code that does not compile. All answers are bitwise identical, but an optional argument (scale) to a publicly visible diagnostic routine (myStats) was renamed.
Hallberg-NOAA
force-pushed
the
unscale_myStats_arg
branch
from
d52e449 to
e2c8246
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24047. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the optional
scaleargument tomyStats()tounscale, mirroring therecent additions of
unscalearguments to the variouschksum()routines. This included changes to 6 calls tomyStats()in the twohoriz_interp_and_extrap_tracer()routines. AlthoughmyStats()is public, it really is only used in MOM_horizontal_regridding in the main version of MOM6, apart from a single call inMOM_initialize_tracer_from_Z()that does not use the optional(un)scaleargument, so rather than adding a second optional argument, this case seemed to be safe enough to rename the argument in place. If there were any unanticipated problems with this argument name change, they would be manifest in code that does not compile. All answers are bitwise identical, but an optional argument (scale) to a publicly visible diagnostic routine (myStats()) was renamed.