+Add a better variant of add_LOTW_BBL_diffusivity #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
the
Parameter change
MJHarrison-GFDL
approved these changes
Jul 1, 2024
marshallward
approved these changes
Jul 9, 2024
Added a refactored version of add_LOTW_BBL_diffusivity that is more accurate by avoiding a subtraction of two large numbers to determine the distance from the surface and more reproducible by avoiding the use of the Fortran sum function. This new version of the code is mathematically equivalent to the original, and it is selected by setting the new runtime parameter LOTW_BBL_ANSWER_DATE to be greater than 20240630. This probably could have been done reusing the existing parameter SET_DIFF_ANSWER_DATE, but this would have meant answer changes for some cases that set this to a high value. By default the original code is used, but the default should be changed later to follow the value of DEFAULT_ANSWER_DATE. By default, all answers are bitwise identical but there is a new runtime parameter in some cases.
Hallberg-NOAA
force-pushed
the
better_add_LOTW_BBL_diff
branch
from
c4791cf to
c92de48
Compare
|
This PR has conditionally passed the pipeline testing at gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24049 with the expected warnings about there being new runtime parameters. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a refactored version of the code in
add_LOTW_BBL_diffusivity()that is more accurate by avoiding a subtraction of two large numbers to determine the distance from the surface and more reproducible by avoiding the use of the Fortransum()function. This new version of the code is mathematically equivalent to the original, and it is selected by setting the new runtime parameterLOTW_BBL_ANSWER_DATEto be greater than 20240630. This probably could have been done reusing the existing parameterSET_DIFF_ANSWER_DATE, but this would have meant answer changes for some cases that set this to a high value. By default the original code is used, but the default should be changed later to follow the value ofDEFAULT_ANSWER_DATE. By default, all answers are bitwise identical but there is a new runtime parameter in some cases.