diffusivities from internal tides ray tracing algo #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaeldussin
force-pushed
the
int_tides_fixes
branch
2 times, most recently
from
ed2353e to
f6c9ef7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #677 +/- ##
============================================
+ Coverage 36.88% 40.90% +4.01%
============================================
Files 271 42 -229
Lines 81692 5286 -76406
Branches 15269 1013 -14256
============================================
- Hits 30132 2162 -27970
+ Misses 45907 2939 -42968
+ Partials 5653 185 -5468 ☔ View full report in Codecov by Sentry. |
raphaeldussin
force-pushed
the
int_tides_fixes
branch
from
f6c9ef7 to
0a9ebe9
Compare
|
Energy budget is closing:
|
raphaeldussin
force-pushed
the
int_tides_fixes
branch
from
0a9ebe9 to
94dbf54
Compare
|
also reproduces over processor counts with N = 480 and N = 441 |
raphaeldussin
force-pushed
the
int_tides_fixes
branch
3 times, most recently
from
1ede7e1 to
5bb32cc
Compare
|
@Hallberg-NOAA PR passes unit scaling tests in Boussinesq .and. Non-Boussinesq |
Hallberg-NOAA
requested changes
Jul 31, 2024
raphaeldussin
force-pushed
the
int_tides_fixes
branch
from
c88ab0e to
aab5f48
Compare
added 14 commits
September 6, 2024 17:26
- TKE_itidal_input values are set to zero where it is not applied to the model so that diagnostics are consistent - removed useless halo updates - diagnose energy loss terms as dE/dt instead of equivalent loss rate to properly close energy budget - tot_vel_btTide2 was already a velocity squared, no need to square again - Froude loss term was not properly initialized - add missing halo updates for internal tide speed - compute residual/critical slopes loss only where it has a meaning, allows to clean up noise in field - uh/vh in energy flux routines do not need to be inout - missing unit scaling for frequency
- put test for negative energt behind debug flag - do energy budget in debug mode - add flags to skip refraction, propagation for debugging - add option to input TKE only at first step for debugging - add checksums for unit scaling testing - rewrite terms in refraction to avoid substractions of velocities - rewrite gradient of coriolis in rotationally invariant form
- MOM_internal_tides gets new routine that converts TKE losses into diffusivities using the TKE_to_Kd array - MOM_set_diffusivities handles the diagnostics
raphaeldussin
force-pushed
the
int_tides_fixes
branch
from
d674e30 to
d4b04fe
Compare
Hallberg-NOAA
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
I have inspected the updated code, and I believe that all issues that were identified previously have been resolved with this code contribution. Well done, @raphaeldussin.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24768 ✔️ These 15 commits will be squash-merged. |
theresa-morrison
pushed a commit
to theresa-morrison/MOM6
that referenced
this pull request
Nov 18, 2024
* (*)bugfixes for internal tides - TKE_itidal_input values are set to zero where it is not applied to the model so that diagnostics are consistent - removed useless halo updates - diagnose energy loss terms as dE/dt instead of equivalent loss rate to properly close energy budget - tot_vel_btTide2 was already a velocity squared, no need to square again - Froude loss term was not properly initialized - add missing halo updates for internal tide speed - compute residual/critical slopes loss only where it has a meaning, allows to clean up noise in field - uh/vh in energy flux routines do not need to be inout * Refactor debugging internal tides - put test for negative energt behind debug flag - do energy budget in debug mode - add flags to skip refraction, propagation for debugging - add option to input TKE only at first step for debugging - add checksums for unit scaling testing - rewrite terms in refraction to avoid substractions of velocities - rewrite gradient of coriolis in rotationally invariant form * Add internal tides diffusivities - MOM_internal_tides gets new routine that converts TKE losses into diffusivities using the TKE_to_Kd array - MOM_set_diffusivities handles the diagnostics * extend find_rho_bottom to get bbl thickness/index * new calculation of BBL, profiles in H units
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better readibility, the PR is split into 3 commits: the first deals with bugfixes and improvements relative to the internal tides energy (changes answers) while the second deals with refactoring of debugging infra. The third commit introduces the TKE loss to diffusivity part.
1st part:
2nd part:
last part: