Improve MOM_surface_chksum #687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gfdl-to-main-2024-05-31 #687 +/- ##
========================================================
Coverage 37.05% 37.05%
========================================================
Files 271 271
Lines 81272 81280 +8
Branches 15162 15166 +4
========================================================
+ Hits 30112 30117 +5
Misses 45523 45523
- Partials 5637 5640 +3 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
force-pushed
the
better_MOM_surface_checksum
branch
2 times, most recently
from
27a7bdd to
ef99a05
Compare
Added checksum calls for the melt_potential, ocean_mass, ocean_heat and ocean_salt elements of the surface state in MOM_surface_chksum if these fields are allocated for more comprehensive debugging. Also added the symmetric optional argument to the call to MOM_surface_chksum form extract_surface_state so that all of the surface velocity values that could contribute to the ocean surface velocities that are seen by the coupler are checksummed. All solutions are bitwise identical, but there are enhancements to the MOM6 debugging capabilities.
Hallberg-NOAA
force-pushed
the
better_MOM_surface_checksum
branch
from
ef99a05 to
2ed2b3d
Compare
|
This very simple PR has been subjected to pipeline testing, but it has conflicts with commits to dev/gfdl subsequent to the 2024-05-31 PR from dev/gfdl to main that can not be resolved automatically. This PR has been effectively reviewed in evaluating whether this PR changes the answers for dev/EMC, and I have manually verified that this does not change answers for the dev/gfdl regression suite. I am going to go out on a limb and declare that this PR has effectively been independently reviews (by Jiande) and that it will pass GFDL's regression testing. |
Hallberg-NOAA
merged commit ee686c8
into
NOAA-GFDL:gfdl-to-main-2024-05-31
Added checksum calls for the
melt_potential,ocean_mass,ocean_heatandocean_saltelements of the surface state inMOM_surface_chksum()if these fields are allocated for more comprehensive debugging. Also added the symmetric optional argument to the call toMOM_surface_chksum()fromextract_surface_state()so that all of the surface velocity values that could contribute to the ocean surface velocities that are seen by the coupler are checksummed. All solutions are bitwise identical, but there are enhancements to the MOM6 debugging capabilities.