Update MOM_wave_interface.F90 #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
I believe that these changes do properly correct a set of bugs. Thank you for this contiribution, @Zeracesharon!
Because the previous version would not pass rotational consistency checks or consistent answers across PE count and layout, I can not imagine the Stokes Drift code was ever used in any solutions we need to retain, so I am OK with simply correcting these bugs without runtime flag to recover the previous answers.
The index at the interface has been changed from I-1 ->i+1 and J-1 -> j+1, which helps fixed model error in 3D simulations while keeping halo_size to 1.
Corrected the index for thickness which fixed the issue of 3D wave coupled simulations while keeping the halo_size in thickness as 1
Hallberg-NOAA
force-pushed
the
dev/gfdl
branch
from
04e2114 to
8778ddc
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/25877 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modified the index of I-1 -> i+1, J-1 -> j+1, which fixed the model error when conducing wave-coupled 3D simulations, keeping halo_size in thickness to be 1.