*Update defaults for EQN_OF_STATE and 14 parameters #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
answer-changing
Hallberg-NOAA
force-pushed
the
update_param_defaults_2024
branch
from
94d95c1 to
2c7362c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #798 +/- ##
=============================================
- Coverage 38.25% 22.01% -16.25%
=============================================
Files 296 136 -160
Lines 86930 32670 -54260
Branches 16150 5791 -10359
=============================================
- Hits 33254 7191 -26063
+ Misses 47751 24951 -22800
+ Partials 5925 528 -5397 ☔ View full report in Codecov by Sentry. |
Updated the default values of 15 runtime parameters, as agreed upon in a MOM6 consortium wide conversations on July 29, 2024 and December 16, 2024. The most prominent of these is that the default equation of state is now EQN_OF_STATE = "WRIGHT_FULL", in place of the buggy previous default of "WRIGHT". The 8 answer date parameters REGRIDDING_ANSWER_DATE, TIDES_ANSWER_DATE, WAVE_INTERFACE_ANSWER_DATE, MEKE_GM_SRC_ANSWER_DATE, NDIFF_ANSWER_DATE, KPP%ANSWER_DATE, HOR_DIFF_ANSWER_DATE and LOTW_BBL_ANSWER_DATE all now take their default values from DEFAULT_ANSWER_DATE. The bug-retention parameters MEKE_GM_SRC_ALT_SLOPE_BUG, HOR_DIFF_LIMIT_BUG, BACKSCATTER_UNDERBOUND, DETERMINE_TEMP_CONVERGENCE_BUG, LA_MISALIGNMENT_BUG and IDL_HURR_SCM_EDGE_TAPER_BUG are now false by default. The MOM_input files for the test cases in the `.testing/tc[01234]` directories were updated to explicitly set all of these parameters to their previous default values. Bitwise identical answers are recovered if all 15 of these parameters are set explicitly, but answers can change if any of these parameters take default values. All of these default changes are the consensus decision of consortium-wise MOM6 dev calls.
Hallberg-NOAA
force-pushed
the
update_param_defaults_2024
branch
from
2c7362c to
1f1c875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the default values of 15 runtime parameters, as agreed upon in a MOM6 consortium wide conversations on July 29, 2024 and December 16, 2024. The most prominent of these is that the default equation of state is now
EQN_OF_STATE = "WRIGHT_FULL", in place of the buggy previous default of "WRIGHT".The 8 answer date parameters
REGRIDDING_ANSWER_DATE,TIDES_ANSWER_DATE,WAVE_INTERFACE_ANSWER_DATE,MEKE_GM_SRC_ANSWER_DATE,NDIFF_ANSWER_DATE,KPP%ANSWER_DATE,HOR_DIFF_ANSWER_DATEandLOTW_BBL_ANSWER_DATEall now take their default values fromDEFAULT_ANSWER_DATE.The bug-retention parameters
MEKE_GM_SRC_ALT_SLOPE_BUG,HOR_DIFF_LIMIT_BUG,BACKSCATTER_UNDERBOUND,DETERMINE_TEMP_CONVERGENCE_BUG,LA_MISALIGNMENT_BUGandIDL_HURR_SCM_EDGE_TAPER_BUGare now false by default.Bitwise identical answers are recovered if all 15 of these parameters are set explicitly, but answers can change if any of these parameters take default values. All of these default changes are the consensus decision of consortium-wise MOM6 dev calls.