-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
217 teaching fre cmor
to bite
#218
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78a6e35
edit cmor_mixer to glob files a lil dfferently. other bug fixes. add …
ilaflott 015c601
quick for two commits Merge branch 'main' into 217-the-cmorbite-one-v…
ilaflott 493c4dd
having run all test cases, a theme of failures is starting to emerge...
ilaflott 153a779
add print statement to wrapper function for easier cli debugging calls
ilaflott 6285283
add comments AND constants detailing what kind of hardcoded things th…
ilaflott 4b31338
alrightly, lets move some of this hardcoding to the top of the file, …
ilaflott 31996b0
fix undefined variable name errors
ilaflott f35599d
grab recent changes, of course. Merge branch 'main' into 217-the-cmor…
ilaflott ff6de5b
Revert "fix undefined variable name errors"
ilaflott 515d56c
Revert "alrightly, lets move some of this hardcoding to the top of th…
ilaflott 434dc3e
bug fix for a case or two, tidy up the presentation of the test cases…
ilaflott 14b08cd
update readme and frecmor.py with better doc strings and help descrip…
ilaflott d80b790
intermediate commit- new function to compar variable dimensions. none…
ilaflott 2f84555
Merge branch 'main' into 217-the-cmorbite-one-variable8-grids
ilaflott 1a15d95
Revert "intermediate commit- new function to compar variable dimensio…
ilaflott e696487
Merge branch 'main' into 217-the-cmorbite-one-variable8-grids
ilaflott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't ever really disagree with documentation, and don't disagree with this, but we'll have to keep this up-to-date with the actual --help output content which is defined elsewhere. Eventually, documentation like this will be auto-created through sphinx somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been pondering this too. hear me out for a second- I know that the way (edit)
we generatei generated coverage badges in our pipeline is a bit hacky- utilizing the deployed github pages to host the generated image at a static URL for linking to the README.But... there DO exist workflows that edit the coverage badge in the repo directly and makes the commit itself- i tried to make those work but couldn't figure it out on a reasonable timeline.
Why do i bring this up? Well, in theory if a workflow could commit to the repo for a generated test-coverage badge, it should also be able to commit a quick README edit based on the latest
fre <tool> --help
orfre <tool> <subtool> --help
. That's tech debt worth noting down for future payment.