Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change conda build source back to path: . from url: <repo url> #310

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

ilaflott
Copy link
Member

@ilaflott ilaflott commented Jan 3, 2025

Describe your changes

apparently conda build . will not listen to the . part and defer to what is under the source: key within meta.yaml.

so if we run conda build . followed by conda publish in .github/workflows/publish_conda.yml, we're publishing old code into the package channel, and not the code that's being merged into main from a PR, no buéno.

Issue ticket number and link (if applicable)

see this PR comment and following pipeline outcomes

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
    - [ ] I wrote a new test, if applicable
    - [ ] I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
    - [ ] I ran pylint and attempted to implement some of it's feedback

@ilaflott ilaflott marked this pull request as ready for review January 3, 2025 21:30
@ilaflott ilaflott merged commit d4a4f4e into main Jan 3, 2025
2 checks passed
@ilaflott ilaflott deleted the hotfix-patch-conda-build-source branch January 3, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants