Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly Resolves performance issues mentioned in #713
Changes
nex_files_to_binary
Old pseudocode
New pseudocode
The data is still being written the same amount of times, but it's mostly plaintext appends which bypasses the expensive parquet IO until the final pass.
Testing
data I used
python -m nwm_routing -V4 config/ngen.yaml
find / -type f -name "AbstractNetwork.py"
Screenshots
Comparison of just file IO sections
master test
PR Changes test
Notes