Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIIRS DA capability for the vector formatted land-only DA workflow #23

Open
wants to merge 84 commits into
base: feature/addVIIRS
Choose a base branch
from

Conversation

yuanxue2870
Copy link
Contributor

@yuanxue2870 yuanxue2870 commented Aug 16, 2024

Describe your changes (READY FOR REVIEW/DO NOT MERGE)

Summarise all code changes included in PR:

  1. added the VIIRS DA capability;
  2. solved all merging conflicts.
    Note: VIIRS ioda converters are likely being merged with IMS at a later date. For now, in this PR, IMS and VIIRS have their own ioda converter individually.  

List any associated PRs in the submodules.

  1. Add VIIRS DA for vector formatted offline workflow land-SCF_proc#9

Issue ticket number and link

List the git Issue that this PR addresses:

  1. Add VIIRS DA capability in the original (vector formatted) land-only DA workflow #21

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Yes. No changes to the output.

Does it pass the DA_IMS_test?
Yes.

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
N/A.

Checklist before requesting a review

  • My branch being merged is up to date with the latest develop.
  • I have performed a self-review of my code by examining the differences that will be merged.
  • I have not made any unnecessary code changes / changed any default behavior.
  • My code passes the DA_IMS_test, or differences can be explained.

@yuanxue2870
Copy link
Contributor Author

Please review: @ClaraDraper-NOAA, @YoulongXia-NOAA, @tsga

Thank you!

@ClaraDraper-NOAA ClaraDraper-NOAA changed the base branch from develop to feature/addVIIRS December 20, 2024 18:48
@ClaraDraper-NOAA
Copy link
Collaborator

Can you please solve this conflicts, then I'll merge it into the PSL feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants