Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ruby documentation, HPXMLtoOpenStudio/measure.rb refactor #1817

Merged
merged 25 commits into from
Sep 17, 2024

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Aug 29, 2024

Pull Request Description

Addresses #1759.

Includes moving most of the HPXMLtoOpenStudio measure.rb code to appropriate resource files, so that the order of object translation can be more easily understood.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

joseph-robertson and others added 23 commits August 30, 2024 09:24
…o ruby-docs

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
…into ruby-docs

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
@shorowit shorowit changed the title More ruby documentation More ruby documentation, HPXMLtoOpenStudio/measure.rb refactor Sep 17, 2024
@shorowit shorowit marked this pull request as ready for review September 17, 2024 04:36
@shorowit shorowit merged commit 7522094 into master Sep 17, 2024
@shorowit shorowit deleted the ruby-docs branch September 17, 2024 04:36
@joseph-robertson joseph-robertson mentioned this pull request Sep 17, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants