Skip to content

Commit

Permalink
add comments and fix a typo
Browse files Browse the repository at this point in the history
Signed-off-by: Haoyang Li <[email protected]>
  • Loading branch information
thirtiseven committed Dec 7, 2023
1 parent a1bd436 commit 290521b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions integration_tests/src/main/python/data_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ def start(self, rand):
class DecimalGen(DataGen):
"""Generate Decimals, with some built in corner cases."""
def __init__(self, precision=None, scale=None, nullable=True, special_cases=None, avoid_positive_values=False, full_precision=False):
"""full_precision: If True, generate decimals with full precision without leading and trailing zeros."""
if precision is None:
#Maximum number of decimal digits a Long can represent is 18
precision = 18
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/src/main/python/date_time_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ def test_timestamp_seconds_long_overflow():
conf={},
error_message='long overflow')

# Make sure every decimal value in test data is rounding necessary by set full_precision=True to
# Make sure every decimal value in test data is 'Rounding necessary' by set full_precision=True to
# avoid leading and trailing zeros
@pytest.mark.xfail(condition = is_not_utc(), reason = 'xfail non-UTC time zone tests because of https://github.com/NVIDIA/spark-rapids/issues/9653')
@pytest.mark.parametrize('data_gen', [DecimalGen(7, 7, full_precision=True), DecimalGen(20, 7, full_precision=True)], ids=idfn)
Expand Down

0 comments on commit 290521b

Please sign in to comment.