-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MockTaskContext to support new functions added in Spark-4.0 [databricks] #11972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
requested review from
gerashegalov,
revans2,
tgravescs,
mythrocks and
razajafri
January 16, 2025 21:21
build |
Looks like the Spark-4 build here doesn't contain the Spark commit which was merged. The nightly build was using URM_URL.
|
tests/src/test/spark400/scala/org/apache/spark/sql/rapids/metrics/source/MockTaskContext.scala
Outdated
Show resolved
Hide resolved
nartal1
changed the title
Move MockTaskContext to shim to support new functions added in Spark-4.0 [databricks]
Update MockTaskContext to support new functions added in Spark-4.0 [databricks]
Jan 17, 2025
This reverts commit 1264cae.
This reverts commit 5436b53.
Signed-off-by: Niranjan Artal <[email protected]>
build |
gerashegalov
previously approved these changes
Jan 17, 2025
Co-authored-by: Gera Shegalov <[email protected]>
build |
gerashegalov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11971 . This unblocks the scala_2.13 nightly build jobs.
MockTaskContext extends TaskContext in spark-rapids code. Recently additional definitions were added in Spark-4.0's TaskContext.
In this PR, we added the missing methods to MockTaskContext.scala file. We are not overriding these methods so that it can compile on all Spark versions.
In Spark-4.0, these were added in TaskContext.scala:
PR : apache/spark#49413