Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST ONLY #9537

Closed
wants to merge 121 commits into from
Closed

TEST ONLY #9537

wants to merge 121 commits into from

Conversation

NvTimLiu
Copy link
Collaborator

No description provided.

NVnavkumar added 30 commits June 20, 2023 20:11
@NVnavkumar
Preliminary Scala 2.13 build support, need to fix compilation errors
77e83c3 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Handle 2 simple updates with scalastyle checks
7c9a930
@NVnavkumar
Update due to requirement of not importing scala.collection.Seq directly
5b41add
@NVnavkumar
One round of code updates for Scala 2.13
02ef278 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Merge branch 'branch-23.10' into scala-213
8adb72e
@NVnavkumar
Style fixes.
ef6a97d
@NVnavkumar
Update RAPIDS shuffle manager code to parallel use of scala.collectio…
a359bec 
…n.Seq from Spark 3.4 and higher.

This is to avoid unnecessary copying of data.
@NVnavkumar
Handle usage of Seq in GpuBindReferences
65e3601
@NVnavkumar
Sub partition hash join updates. Follow the recommended scala pattern…
bc5d337 
… of converting when returning Seq and using Seq in _* pattern
@NVnavkumar
Handle ArrayStack usage in GpuSortExec and SortUtils
ce9054e
@NVnavkumar
Regex parser fixes.
272725e
@NVnavkumar
Parquet Scan Seq usage.
cd7a132
@NVnavkumar
Orc scan Seq usage.
ac75ac6
@NVnavkumar
Multi file reader Seq usage.
c5f7bff
@NVnavkumar
Hive CTAS command fixes
4b69ec9
@NVnavkumar
miscellaneous scan usage of Seq
4714ca6
@NVnavkumar
Fix procedure syntax.
85c0af9
@NVnavkumar
Add procedure declaration checker since it's fully deprecated in Scal…
144e442 
…a 2.13 and will cause compilation to fail

Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Add scala versions here based on Spark
a38a91a
@NVnavkumar
Merge branch 'branch-23.10' into scala-213
a9bd68e
@NVnavkumar
Move these files to scala 2.12 only compilation
8db9a16
@NVnavkumar
Restore these to the original scala 2.12 compatible versions
69d7b44 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Merge updates from upstream sort changes.
fec9f0c
@NVnavkumar
Forking Arm because of collection hierarchy handling
abf994f
@NVnavkumar
Updated forked versions for Scala 2.13
577e5a4
@NVnavkumar
Updated toSeq usage for Scala 2.13
130e52c
@NVnavkumar
Handle forked scala-2.12 and scala-2.13 directories for build
bf24baa
@NVnavkumar
For Scala 2.13 need to convert Set to Seq when using .map(). This is …
220e0d3 
…to avoid an Ordering requirement.
@NVnavkumar
Need to fork aggregate.scala because of Product with Serialize supert…
742e043 
…ype of case objects.
@NVnavkumar
Handle failed implicit SAM conversion for Scala 2.13
6d50c1e 
Signed-off-by: Navin Kumar <[email protected]>
NVnavkumar and others added 16 commits October 22, 2023 21:19
@NVnavkumar
Fix premerge profile for Scala 2.13
7011a5a 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Fix Jenkins MVN_URM_MIRROR
6279a06 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Need these to match up properly
0892562 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Revert this change
82456ae 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Create symlink when handling relative jenkins path
096d775 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Fix symlink command
ab25ace 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Merge branch 'branch-23.12' of github.com:NVIDIA/spark-rapids into sc…
835e29b 
…ala-213
@NVnavkumar
Merge branch 'branch-23.12' of github.com:NVIDIA/spark-rapids into sc…
be09252 
…ala-213
@NVnavkumar
Fix toSeq issue in GpuSemaphore
b8b6463 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Merge branch 'branch-23.12' of github.com:NVIDIA/spark-rapids into sc…
6277529 
…ala-213
@NVnavkumar
Update noSnapshots profile in Scala2.13 for CI purposes.
e7301f6
@NVnavkumar
Update premerge to run Integration tests for Scala 2.13
4c359e7 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Merge branch 'branch-23.12' of github.com:NVIDIA/spark-rapids into sc…
c138485 
…ala-213
@NVnavkumar
More pom file updates from upstream
92dbb00 
Signed-off-by: Navin Kumar <[email protected]>
@NVnavkumar
Update premerge build script to separate out 2.13 tasks.
f52907c 
Signed-off-by: Navin Kumar <[email protected]>
@NvTimLiu
Update CI script to support for scala 2.13
4867ba2 
Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu NvTimLiu marked this pull request as draft October 25, 2023 12:11
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu
Copy link
Collaborator Author

build

@jlowe
Copy link
Contributor

jlowe commented Oct 31, 2023

@NvTimLiu the Scala 2.13 support has been merged -- is this still needed?

@pxLi
Copy link
Collaborator

pxLi commented Nov 1, 2023

@NvTimLiu the Scala 2.13 support has been merged -- is this still needed?

this should be used for test only. Tim is on vacation, let me close this one for now

@pxLi pxLi closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe Awaiting requested review from jlowe

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@pxLi pxLi Awaiting requested review from pxLi pxLi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NvTimLiu @jlowe @pxLi @NVnavkumar