Preparation for non-UTC nightly CI [skip ci] #9885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <[email protected]>
res-life
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
pxLi
as code owners
|
build |
pxLi
reviewed
Nov 29, 2023
| @@ -321,6 +335,11 @@ if [[ "$TEST_MODE" == "DEFAULT" || "$TEST_MODE" == "PYARROW_ONLY" ]]; then | |||
| run_pyarrow_tests | |||
| fi | |||
|
|
|||
| # Non-UTC time zone tests | |||
| if [[ "$TEST_MODE" == "NON_UTC_TZ" ]]; then | |||
There was a problem hiding this comment.
please also add comment to explain the MODE in above TEST_MODE section thx
pxLi
changed the title
|
(killed previous trigger) also [skip ci] to save resources, nightly update would not be covered in pre-merge |
pxLi
reviewed
Nov 29, 2023
jenkins/spark-tests.sh
Outdated
| # select one time zone according to date | ||
| non_utc_time_zones=("Asia/Shanghai" "Iran") | ||
| time_zones_length=${#non_utc_time_zones[@]} | ||
| current_date=$(date +%Y%m%d) |
There was a problem hiding this comment.
nit: may use the date +%w to get day of week, so schedule is fixed unlike depends on date YearMD number
pxLi
added
build
|
build |
pxLi
approved these changes
Nov 29, 2023
|
merge this one to setup pipeline in advance |
|
regular non-utc run should still wait for #9719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #9855
Preparation for non-UTC nightly CI
Select a non-UTC time zone according to day of week, then test.
Depending on #9719