Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make valid: 131/typecheck and 132/heroku-cli #133

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Make valid: 131/typecheck and 132/heroku-cli #133

merged 2 commits into from
Dec 23, 2024

Conversation

TangoYankee
Copy link
Member

Description

Two tickets and two commits on one PR to get the Repository back into a cohesive state

@TangoYankee
Correct typecheck error
8feb1d3 
Refactor logic to check undefined and null separately

closes #131
@TangoYankee
Upgrade github action runner environment
54bb870 
Manually install heroku-cli

closes #132
pratishta
pratishta approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@pratishta pratishta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐬

@TangoYankee TangoYankee merged commit 2e30849 into main Dec 23, 2024
1 check passed
@TangoYankee TangoYankee deleted the make-valid branch December 23, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratishta pratishta pratishta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manually install heroku cli Typecheck error
2 participants
@TangoYankee @pratishta