Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

293/upgrade node 20 #344

Merged
merged 2 commits into from
Jul 24, 2024
Merged

293/upgrade node 20 #344

merged 2 commits into from
Jul 24, 2024

Conversation

TangoYankee
Copy link
Member

@TangoYankee TangoYankee commented Jul 24, 2024 •
edited
Loading

Update to node 20

  • update nvmrc
  • add engines field and pin to 20.x
  • reinstall node modules

closes #293

Note: removing the leftover "only" from a test is intentionally a separate commit

@TangoYankee
reinstate capital project tests
e7ae7b4
@TangoYankee
Update to node 20
e2d1c2b 
- update nvmrc
- add engines field and pin to 20.x
- reinstall node modules

closes #293
@TangoYankee TangoYankee requested a review from a team July 24, 2024 14:46
horatiorosa
horatiorosa approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@horatiorosa horatiorosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this looks ok-ish

@TangoYankee TangoYankee merged commit 27f557f into main Jul 24, 2024
3 checks passed
@TangoYankee TangoYankee deleted the 293/upgrade-node-20 branch November 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horatiorosa horatiorosa horatiorosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to node 20
2 participants
@TangoYankee @horatiorosa