Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fix use of pluto change files #252

Merged
merged 20 commits into from
Feb 9, 2023
Merged

fix use of pluto change files #252

merged 20 commits into from
Feb 9, 2023

Conversation

damonmcc
Copy link
Member

@damonmcc damonmcc commented Feb 8, 2023 •
edited
Loading

changes

  • generalize approach to getting pluto change zip file and csv files to accommodate filename changes introduced in Switch to just using PLUTO manual research for corrections db-pluto#425
  • preserve backwards compatibility by always looking for both new and old sets of filename
  • use pluto_changes_applied.csv for Review Manual Corrections section of PLUTO QAQC page
  • simplify uses of DigitalOceanClient in all helpers.py files
  • add an example.env file
  • impore intro section of PLUTO page
  • update readme dev details

@damonmcc damonmcc linked an issue Feb 8, 2023 that may be closed by this pull request
fix error from new pluto_corrections zip name and one less file #251
Closed
@damonmcc damonmcc changed the title fix use of pluto changes files fix use of pluto change files Feb 8, 2023
@damonmcc damonmcc self-assigned this Feb 8, 2023
mbh329
mbh329 reviewed Feb 9, 2023
View reviewed changes
src/pluto/helpers.py Outdated Show resolved Hide resolved
@damonmcc damonmcc requested a review from mbh329 February 9, 2023 19:59
mbh329
mbh329 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@mbh329 mbh329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - nice removing duplicative code in the repo level python files

mbh329
mbh329 reviewed Feb 9, 2023
View reviewed changes
src/digital_ocean_client.py
@@ -39,14 +39,20 @@ def s3_resource(self):
endpoint_url=os.getenv("AWS_S3_ENDPOINT"),
)

def get_all_folders_in_repo(self):
def get_all_folder_names_in_repo_folder(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function names are much more detailed...NOICE

@damonmcc
Copy link
Member Author

damonmcc commented Feb 9, 2023

made and tested replacing correction with changes in both text and code

@damonmcc damonmcc merged commit 40349dc into master Feb 9, 2023
@damonmcc damonmcc deleted the 251-fix-error-when-pluto_corrections-doesnt-exist branch February 9, 2023 22:06
@damonmcc damonmcc mentioned this pull request Feb 10, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbh329 mbh329 mbh329 approved these changes

Assignees

@damonmcc damonmcc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix error from new pluto_corrections zip name and one less file
2 participants
@damonmcc @mbh329