Fvk socrata tweaks #1344
Draft
Fvk socrata tweaks #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvankrieken
force-pushed
the
fvk-socrata-tweaks
branch
2 times, most recently
from
840743c to
c659320
Compare
fvankrieken
commented
Dec 23, 2024
dcpy/connectors/socrata/publish.py
Outdated
| ) | ||
| if our_col.custom and our_col.custom.get("api_name"): | ||
| logger.info(f"Mapping column {our_col.id} to {col}") | ||
| output_schema.change_column_transform(col).to(f"`{our_col.id}`") |
There was a problem hiding this comment.
this probably should be our_col.name.lower() rather than our_col.id - as far as I can tell, that's how socrata reads in the datasets
fvankrieken
commented
Dec 23, 2024
| @@ -594,6 +593,7 @@ def push_dataset( | |||
| for attachment_id in socrata_dest.attachment_ids | |||
| ] | |||
|
|
|||
| dataset.discard_open_revisions() | |||
There was a problem hiding this comment.
I should remember to take this out 🙂
fvankrieken
commented
Dec 23, 2024
| output_schema.change_column_metadata(field_name, "position").to( | ||
| our_col_index + 1 | ||
| ) | ||
| # .change_column_metadata(col, "initial_output_column_id").to(col.id) |
There was a problem hiding this comment.
left this as a comment but seems like this is handled under the hood when using the socratapy methods
alexrichey
force-pushed
the
ar-socrata-bytes-gha
branch
3 times, most recently
from
dd3a0ab to
a7a8f89
Compare
fvankrieken
force-pushed
the
fvk-socrata-tweaks
branch
from
19a1221 to
8ef3894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexrichey - tried to keep things pretty 1-1 with existing code for now.
See https://data.cityofnewyork.us/City-Government/2010-Census-Blocks-water-areas-included-/jyp7-eqhh/revisions/44 - metadata being applied correctly
This isn't quite right yet. there are some default transformations