Issue/1197 fix table layout #1199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-factfinder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
horatiorosa
force-pushed
the
issue/1197-fix-table-layout
branch
from
f19eade to
9ee60fe
Compare
horatiorosa
force-pushed
the
issue/1197-fix-table-layout
branch
from
9ee60fe to
2cc6900
Compare
TylerMatteo
requested changes
May 15, 2024
| @@ -43,6 +44,21 @@ export default Component.extend({ | |||
| return false; | |||
| }), | |||
|
|
|||
| displayEmptyCell: computed('rowConfig', 'pop', function () { | |||
There was a problem hiding this comment.
Can you explain what this property represents and why you need it? I'm having a hard time following the code.
There was a problem hiding this comment.
I will have to hold off on requesting a review. I need to make further changes to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the broken table layout mentioned in Issue 1197's comment
Tasks/Bug Numbers