Skip to content

Commit

Permalink
Merge pull request #1911 from NYPL-Simplified/NOREF-OEB-config-updates
Browse files Browse the repository at this point in the history
OEB Configuration Updates
  • Loading branch information
mwbenowitz authored Nov 16, 2023
2 parents 662cc7e + d30c7d0 commit 28b876a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion api/clever/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"1": "E",
"2": "E",
"3": "E",
"4": "M", # Middle
"4": "E", # Middle
"5": "M",
"6": "M",
"7": "M",
Expand Down
3 changes: 3 additions & 0 deletions api/clever/title_i.json
Original file line number Diff line number Diff line change
Expand Up @@ -8681,6 +8681,9 @@
"063432013803",
"063432013878",
"063432013916",
"063432014499",
"063432014500",
"063432014617",
"063441002774",
"063441005369",
"063441005585",
Expand Down
4 changes: 2 additions & 2 deletions tests/clever/test_clever.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ def test_external_type_from_clever_grade(self):
THEN: The matching external_type value should be returned, or None if the match fails
"""
for e_grade in [
"InfantToddler", "Preschool", "PreKindergarten", "TransitionalKindergarten", "Kindergarten", "1", "2", "3"
"InfantToddler", "Preschool", "PreKindergarten", "TransitionalKindergarten", "Kindergarten", "1", "2", "3", "4"
]:
assert external_type_from_clever_grade(e_grade) == "E"

for m_grade in ["4", "5", "6", "7", "8"]:
for m_grade in ["5", "6", "7", "8"]:
assert external_type_from_clever_grade(m_grade) == "M"

for h_grade in ["9", "10", "11", "12", "13", "PostGraduate"]:
Expand Down

0 comments on commit 28b876a

Please sign in to comment.