Support 1.21.2 - 1.21.4 #98
Conversation
|
I created #104 to add support for 1.21.4 based on your work, thanks! |
|
I updated to 1.21.4, but something might have broken on older versions. Let me know if something breaks |
|
1.21.1 - Network protocol error |
Fixed 1.21.1. However, I can't reproduce the bug on 1.20.6. How does it look for you? Everything is correct for me. |
|
1.21.1 - Network protocol error has been fixed. 1.20.6, 1.21.1 - Background still not black. before: |
There was a problem hiding this comment.
Shouldn't it be changed like this?
if (version.moreOrEqual(Version.V1_21)) {
msg.writeVarInt(dimensionRegistry.getDimension_1_21().getId());
}
else {
msg.writeVarInt(dimensionRegistry.getDimension_1_20_5().getId());
}
Applying this will fix the issue in 1.21.1, but will still cause issues in 1.20.5.
| @@ -300,6 +300,28 @@ public void encode(ByteMessage msg, Version version) { | |||
| msg.writeVarInt(0); | |||
There was a problem hiding this comment.
^
msg.writeVarInt(dimensionRegistry.getDimension_1_20_5().getId());
There was a problem hiding this comment.
if (version.moreOrEqual(Version.V1_21)) {
msg.writeVarInt(dimensionRegistry.getDimension_1_21().getId());
}
else {
msg.writeVarInt(dimensionRegistry.getDimension_1_20_5().getId());
}
There was a problem hiding this comment.
Codec 1.20.5 and 1.21 use the same dimension ids, so this is not required
Ohh, looks like I messed up the dimension IDs. In your screenshot it's the_nether. |
Mojang changed the LoginSuccess, JoinGame and PlayerPositionAndLook packets.
And also starting from 1.20.5 it is no longer necessary to send the client a full codec with registers.
Instead, a KnownPacks and UpdateTags packets is sent which synchronizes the registers, just like the vanilla server does.
In addition, all dependencies have been updated and some places in the code have been improved.
I also added github actions to automatically build a jar file when creating a release.