Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability improvements for mode-converter topology-optimization tutorial script #2874

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Jul 28, 2024

Various improvements to Python readability for the script used in Tutorial/Broadband Waveguide Mode Converter with Minimum Feature Size. This mainly involved adding docstrings and renaming function and variable names.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.78%. Comparing base (f29a8c7) to head (c7a8508).
Report is 25 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2874      +/-   ##
==========================================
- Coverage   73.81%   73.78%   -0.04%     
==========================================
  Files          18       18              
  Lines        5423     5428       +5     
==========================================
+ Hits         4003     4005       +2     
- Misses       1420     1423       +3     

@oskooi oskooi merged commit 12e8a93 into NanoComp:master Jul 28, 2024
5 checks passed
@oskooi oskooi deleted the mode_converter_tutorial_fixes branch July 28, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants