Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth2-to-Near-relay: minor improvements, tests improvements and fixes #818

Merged
merged 56 commits into from
Sep 28, 2022
Merged

Eth2-to-Near-relay: minor improvements, tests improvements and fixes #818

merged 56 commits into from
Sep 28, 2022

Conversation

olga24912
Copy link
Contributor

@olga24912 olga24912 commented Sep 19, 2022 •
edited
Loading

  • separate all files path into config
  • generate tests files for goerli network

#790

@olga24912
fix API for goerli
4def692
@olga24912
fix sync committee for submitting light client update between period
ba1624d
@olga24912
checks for empty headers submittion
11e3e37
@olga24912
timeout on client call
48c4ade
@olga24912
search for valid signature_slot
747738e
@olga24912
arg for submit only finalized blocks
2198169
@olga24912
:sleep 20 secs if on time
381464e
@olga24912
skip signature slot with empty attestations
f695535
@olga24912
fix don't decrement unsigned int
fb090b4
@olga24912
sleep before new iteration
6d9c168
@olga24912
is_sync for beacon client
fc62e3a
@olga24912
fix after rebase
0ea9087
@olga24912
check syncing for Eth1
ba2a295
@olga24912
wait for sync
9679949
@olga24912
separate timeout to config
c212c3e
@olga24912
check account id
3175b40
@olga24912
check near is sync
5499973
@olga24912
parse URL on init
f5a41f4
@olga24912
config for tests
c9129c0
@olga24912
fix tests
bdc1ecf
@olga24912
fix eth2near_relay tests
f487253
@olga24912
fix hand made finality light client updates
fdfeebc
@olga24912
execution_block_proof
2faaf20
@olga24912
fix tests for eth1_rpc_client
1afefcb
@olga24912
fix beacon_rpc_client tests
ea10ca6
@olga24912
fix: init contract by owner
c1df6cf
@olga24912
fix tests for contract wrapper
d22f4ab
@olga24912
fix tests for finality-update-verify
a54752b
@olga24912
rename test files
c87c71a
@olga24912
goerli test data
feb9b28
@olga24912 olga24912 force-pushed the eth2near-relay-configurable-tests branch from 481362f to b859cab Compare September 22, 2022 05:40
@olga24912 olga24912 requested a review from sept-en September 22, 2022 08:20
@sept-en
Copy link
Contributor

sept-en commented Sep 22, 2022 •
edited
Loading

@olga24912 please merge the master branch into PR's branch

@olga24912 olga24912 mentioned this pull request Sep 24, 2022
Merged
sept-en
sept-en suggested changes Sep 27, 2022
View reviewed changes
.github/workflows/contracts-near.yml Outdated Show resolved Hide resolved
karim-en
karim-en requested changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@karim-en karim-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests is failing.

Also please add a comment to the ./test.sh script, to clarify how to run the tests locally

#export API_KEY=<YOUR_INFURA_API_KEY>

@sept-en sept-en changed the title Eth2Near-Relay: fix tests and make tests configurable Eth2-to-Near-Relay: fix tests and make tests configurable Sep 28, 2022
@sept-en sept-en changed the title Eth2-to-Near-Relay: fix tests and make tests configurable Eth2-to-Near-relay: fix tests and make tests configurable Sep 28, 2022
sept-en
sept-en reviewed Sep 28, 2022
View reviewed changes
eth2near/eth2near-block-relay-rs/src/eth1_rpc_client.rs
@@ -35,6 +35,8 @@ impl Eth1RPCClient {
let val: Value = serde_json::from_str(&res)?;
let mut block_json = serde_json::to_string(&val["result"])?;

println!("{}", block_json);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, IMO this line shouldn't be here

@sept-en sept-en changed the title Eth2-to-Near-relay: fix tests and make tests configurable Eth2-to-Near-relay: minor improvements, tests improvements and fixes Sep 28, 2022
@sept-en sept-en merged commit dab74e4 into master Sep 28, 2022
@sept-en sept-en deleted the eth2near-relay-configurable-tests branch September 28, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sept-en sept-en sept-en approved these changes

@karim-en karim-en karim-en approved these changes

Assignees

@sept-en sept-en

@olga24912 olga24912

@karim-en karim-en

Labels
relayers rust Pull requests that update Rust code testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olga24912 @sept-en @karim-en