Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth2Near-relay: add extra metrics to Prometheus #824

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Eth2Near-relay: add extra metrics to Prometheus #824

merged 2 commits into from
Sep 24, 2022

Conversation

olga24912
Copy link
Contributor

@olga24912 olga24912 requested a review from sept-en as a code owner September 23, 2022 11:19
@olga24912 olga24912 force-pushed the eth2near-relay-issue822 branch from c81d830 to 38804dd Compare September 23, 2022 14:15
@sept-en sept-en requested a review from karim-en September 23, 2022 15:24
@sept-en sept-en added enhancement relayers rust Pull requests that update Rust code labels Sep 23, 2022
sept-en
sept-en approved these changes Sep 23, 2022
View reviewed changes
eth2near/eth2near-block-relay-rs/src/eth2near_relay.rs
FAILS_ON_HEADERS_SUBMISSION, FAILS_ON_UPDATES_SUBMISSION, LAST_ETH_SLOT, LAST_ETH_SLOT_ON_NEAR,
LAST_FINALIZED_ETH_SLOT, LAST_FINALIZED_ETH_SLOT_ON_NEAR,
};
use crate::prometheus_metrics::{CHAIN_EXECUTION_BLOCK_HEIGHT_ON_ETH, CHAIN_EXECUTION_BLOCK_HEIGHT_ON_NEAR, CHAIN_FINALIZED_EXECUTION_BLOCK_HEIGHT_ON_ETH, CHAIN_FINALIZED_EXECUTION_BLOCK_HEIGHT_ON_NEAR, FAILS_ON_HEADERS_SUBMISSION, FAILS_ON_UPDATES_SUBMISSION, LAST_ETH_SLOT, LAST_ETH_SLOT_ON_NEAR, LAST_FINALIZED_ETH_SLOT, LAST_FINALIZED_ETH_SLOT_ON_NEAR};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't import and just use in the code like prometheus_metrics::CHAIN_EXECUTION_BLOCK_HEIGHT_ON_ETH.
The crate is already imported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it is worth deferring it to the separate PR, so as to not bloat up the scope of the current one.

eth2near/eth2near-block-relay-rs/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
eth2near/eth2near-block-relay-rs/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
eth2near/eth2near-block-relay-rs/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
eth2near/eth2near-block-relay-rs/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
eth2near/eth2near-block-relay-rs/src/prometheus_metrics.rs Outdated Show resolved Hide resolved
@sept-en sept-en merged commit 3981435 into master Sep 24, 2022
@sept-en sept-en deleted the eth2near-relay-issue822 branch September 24, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sept-en sept-en sept-en approved these changes

@karim-en karim-en Awaiting requested review from karim-en karim-en is a code owner

Assignees

@sept-en sept-en

@olga24912 olga24912

@karim-en karim-en

Labels
enhancement relayers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olga24912 @sept-en @karim-en