Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contract-wrapper: improve documentation #827

Merged
merged 9 commits into from
Oct 1, 2022
Merged

contract-wrapper: improve documentation #827

merged 9 commits into from
Oct 1, 2022

Conversation

olga24912
Copy link
Contributor

@olga24912 olga24912 requested a review from sept-en as a code owner September 26, 2022 18:39
sept-en
sept-en suggested changes Oct 1, 2022
View reviewed changes
eth2near/contract_wrapper/src/contract_wrapper_trait.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/contract_wrapper_trait.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/contract_wrapper_trait.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/contract_wrapper_trait.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/contract_wrapper_trait.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/near_contract_wrapper.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/near_contract_wrapper.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/sandbox_contract_wrapper.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/sandbox_contract_wrapper.rs Outdated Show resolved Hide resolved
eth2near/contract_wrapper/src/sandbox_contract_wrapper.rs Outdated Show resolved Hide resolved
sept-en
sept-en approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @olga24912, please note that this doesn't close the issue completely because Cargo.toml still lacks an appropriate description.

@sept-en sept-en changed the title Eth2NEAR-relay: Comments for contract-wrapper contract-wrapper: improve documentation Oct 1, 2022
@sept-en sept-en added docs relayers rust Pull requests that update Rust code labels Oct 1, 2022
@sept-en sept-en merged commit a8b4360 into master Oct 1, 2022
@sept-en sept-en deleted the eth2near-relay-contract-wrapper-comments branch October 1, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sept-en sept-en sept-en approved these changes

Assignees

@sept-en sept-en

@olga24912 olga24912

Labels
docs relayers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olga24912 @sept-en