-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow override of key location and remove old version support #227
Conversation
b5e21c8
to
75f640d
Compare
77156e1
to
211181f
Compare
This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment) The idea is to allow a device level environment variable `SWARM_KEY_URI_OVERRIDE` in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue. This additionally changes the following: - we hard code the gateway_mfr_rs version in the [test](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi-test.yml) and [production](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi.yml) python package build actions, so there is no need to support old versions of gateway-mfr-rs - due to removing the above, there is also no need to keep the KEY_STORAGE_BUS key in the hardware variants as this is not used anywhere else that I'm aware of **(we should double check this in config, diag, miner, packet forwarder and multiplexer containers just to be 100% sure)** - [Used as a fallback in diag](https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/utilities/hardware.py#L200) but not required Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: #221 Relates-to: #222
5026742
to
bef8272
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
- add override of swarm key location via environment variable - additionally make the indentation in file the same everywhere - add helium OG specific config Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: NebraLtd/hm-pyhelper#227 Relates-to: NebraLtd/hm-diag#503
Thank you @shawaj |
No it's not that simple. Also the update hasn't made it into production yet we are still testing it. Once it's there we will document it :-) |
@shawaj There are two devices with this issue in my fleet that I shared with you, if you want to test the patch on them. |
Issue
How
This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment)
The idea is to allow a device level environment variable
SWARM_KEY_URI_OVERRIDE
in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue.This additionally changes the following:
Screenshots
References
Relates-to: NebraLtd/helium-syncrobit#2
Relates-to: #221
Relates-to: #222
Checklist