add divrem for EuclideanRingResidueRing #1921
Open
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
+ Coverage 88.17% 88.19% +0.01%
==========================================
Files 120 120
Lines 30303 30342 +39
==========================================
+ Hits 26719 26759 +40
+ Misses 3584 3583 -1 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Dec 4, 2024
src/generic/Residue.jl
Outdated
|
|
||
| #horrible - and copied from fmpz_mod | ||
| #don't know how to seriously simplify it | ||
| #maybe a durect gcdx should be added as well |
There was a problem hiding this comment.
Suggested change
| #maybe a durect gcdx should be added as well | |
| #maybe a direct gcdx should be added as well |
|
Add some tests? |
|
I am a bit confused. The code is for residue rings of euclidean rings, but then does something with leading coefficients? |
|
On Thu, Dec 05, 2024 at 05:29:11AM -0800, Tommy Hofmann wrote:
I am a bit confused. The code is for residue rings of euclidean rings, but then does something with leading coefficients?
We can try to do it with canonical_unit? The probelm is that coprime
base and gcd loose the units
… --
Reply to this email directly or view it on GitHub:
#1921 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
possibly we need a more sane algorithm? |
|
How about just doing the Euclidean division in the "base ring" and then project down? |
|
On Thu, Dec 05, 2024 at 07:37:57AM -0800, Tommy Hofmann wrote:
How about just doing the Euclidean division in the "base ring" and then project down?
I guess it comes down to what euc. function we want on the quotient?
For Z/nZ we choose phi(a) = gcd(a, n) you're suggesting to use on R/mR
- choose the euc-minimal rep of a + mR
- euc(a)?
but keep the canonical unit? and not try to do eps a to find a minimal
rep?
… --
Reply to this email directly or view it on GitHub:
#1921 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would resolve oscar-system/Oscar.jl#4340