Add basic conformance tests for is_irreducible #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1952 +/- ##
==========================================
+ Coverage 88.21% 88.24% +0.02%
==========================================
Files 119 119
Lines 30427 30427
==========================================
+ Hits 26842 26851 +9
+ Misses 3585 3576 -9 ☔ View full report in Codecov by Sentry. |
fingolfin
commented
Jan 9, 2025
Comment on lines
+741
to
+750
| @testset "Basic properties" begin | ||
| try | ||
| flag = is_irreducible(x) | ||
| @test flag || is_trivial(R) | ||
| catch e | ||
| if !(e isa NotImplementedError) | ||
| rethrow(e) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This bit here is not yet done. The idea is to consider the test as passing if it throws a NotImplementedError. It's cumbersome this way (and not yet correct). Perhaps a @test_if_implemented macro could handle it nicer for use in other places. Or perhaps we investigate a completely different approach and e.g. add a trait can_compute(R, is_irreducible), that may be more reliable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.