Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two redundant methods #1496

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Remove two redundant methods #1496

merged 1 commit into from
Jun 20, 2023

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Jun 16, 2023

Both are already provided by AA. In fact these methods are examples of type piracy.

Address part of issue #1495

Both are already provided by AA. In fact these methods are examples of type piracy
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1496 (b7df0da) into master (b67abf2) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   88.82%   88.81%   -0.02%     
==========================================
  Files          89       89              
  Lines       34301    34296       -5     
==========================================
- Hits        30468    30460       -8     
- Misses       3833     3836       +3     
Impacted Files Coverage Δ
src/flint/fmpz.jl 93.77% <ø> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma thofma merged commit c464855 into Nemocas:master Jun 20, 2023
@fingolfin fingolfin deleted the mh/redundant branch June 23, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants