Remove redundant {swap,reverse}_{rows,cols} methods #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
reviewed
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
+ Coverage 88.00% 88.02% +0.01%
==========================================
Files 98 98
Lines 36450 36356 -94
==========================================
- Hits 32078 32002 -76
+ Misses 4372 4354 -18 ☔ View full report in Codecov by Sentry. |
The removed methods were identical to the generic methods in AA.
fingolfin
force-pushed
the
mh/swap_reverse_rows_cols
branch
from
38fd841 to
f428c3a
Compare
lgoettgens
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed methods were identical to the generic methods in AA.