Interface and logic to support snap sync for Paprika #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handling of boundary node (only hash stored) - checking root hash without commit - encoding keccak hash as NibblePath for merkle Leaf type - IReadOnlyWorldState implementation for BlockState
…rt healing tests.
- handling of boundary node (only hash stored) - checking root hash without commit - encoding keccak hash as NibblePath for merkle Leaf type - IReadOnlyWorldState implementation for BlockState
…rt healing tests.
…into snap-sync
…mo. Added ForceFlush to aid testing.
- handling of boundary node (only hash stored) - checking root hash without commit - encoding keccak hash as NibblePath for merkle Leaf type - IReadOnlyWorldState implementation for BlockState
…rt healing tests.
- handling of boundary node (only hash stored) - checking root hash without commit - encoding keccak hash as NibblePath for merkle Leaf type - IReadOnlyWorldState implementation for BlockState
…rt healing tests.
…calculate storage root hash.
… BlockState implementation.
…en processing snap sync response.
Scooletz
requested changes
Dec 23, 2024
| private class SyncBlockState : BlockState | ||
| { | ||
| private readonly PooledSpanDictionary _proofKeys; | ||
| private readonly HashSet<ulong> _proofHashSet; |
There was a problem hiding this comment.
How big is it? Have you considered BitFilter here?
There was a problem hiding this comment.
This should not be big - max 2 x height of the synced trie.
|
|
||
| public void RecalculateStorageTries(ICommitWithStats commit, CacheBudget budget) | ||
| { | ||
| using (_storageProcessing.Measure()) |
There was a problem hiding this comment.
Is this measurement useful here? It's used for regular node running so that we can attach with dotnet counters I'd remove.
There was a problem hiding this comment.
This method was removed, but removed I removed gathering these metrics for RecalculateStorageTrie. This can be useful for measuring sync performance.
Co-authored-by: Szymon Kulec <[email protected]>
Minimum allowed line rate is |
Scooletz
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement changes to the
IRawStateinterface required to fully support sync process for Paprika:RlpMemowhich contains hashes of child nodes outside of currently processed data ranges (account or storage). Merkle data created for snap sync is used only to ensure correct root hash calculation and is not persisted onCommit(newEntryType-Proof.CreateMerkleBranchCreateMerkleExtension,CreateMerkleLeaf