Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends BitFilter to make it faster. Tracing shows that up to 8% of the block execution falls into the
BitFilter
creation. By making it faster, we can improve the time before other endeavors like #417 are taken. This PR:Page.OrWith
by unrolling the loop and making two vectorized operations per spin that gives ~20% improvementOfN
bit filter so that it uses a generic<TSize>
parameter that allows to skip the length, mask and shift fieldsOverall,
BitFilter
creation is ~60% faster now (depends on the number of ancestors).The allocation on the filter comes mostly from
Parallel.For
that allocates 3.6kb on its own. It looks that we need to pay the cost.Benchmarks
Page.OrWith
BitFiler.OrWith
Assembly
The assembly for
Page.OrWith
Before
After