Explicit stats for blocks #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces explicitly stored statistics for a block. This allows fast iteration over values without having them actually re-retrieved from the
_stateor_storage. It also removes the need of visiting with the filtering.This should help to address the gap visible in storage processing, where previously
OnStoragethat does the actual job was running roughly through the 50% of the visit time. The rest was probably spent on filtering.The synthetic benchmark and comparison shows huge gains by omitting the visiting aspect and acting directly on the data.
Benchmarks
Overhead
Diff