feat: updated lookahead buffer size

NethermindEth · Oct 3, 2024 · 87d6aa4 · 87d6aa4
1 parent 6365096
commit 87d6aa4
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/SmartContracts/src/avs/PreconfTaskManager.sol b/SmartContracts/src/avs/PreconfTaskManager.sol
@@ -26,13 +26,13 @@ contract PreconfTaskManager is IPreconfTaskManager, Initializable {
 
     // A ring buffer of upcoming preconfers (who are also the L1 validators)
     uint256 internal lookaheadTail;
-    uint256 internal constant LOOKAHEAD_BUFFER_SIZE = 64;
+    uint256 internal constant LOOKAHEAD_BUFFER_SIZE = 128;
     LookaheadBufferEntry[LOOKAHEAD_BUFFER_SIZE] internal lookahead;
 
     // A ring buffer that maps the block height to the associated proposer
     // This is required since the stored block in Taiko has the address of this contract as the proposer
     // Stores 2 epochs worth of L2 blocks = 256 (4 blocks / slot)
-    uint256 internal constant BLOCK_ID_TO_PROPOSER_BUFFER_SIZE = LOOKAHEAD_BUFFER_SIZE * 4;
+    uint256 internal constant BLOCK_ID_TO_PROPOSER_BUFFER_SIZE = PreconfConstants.TWO_EPOCHS * 4;
     mapping(uint256 blockId_mod_BLOCK_ID_TO_PROPOSER_BUFFER_SIZE => ProposerInfo proposerInfo) internal
         blockIdToProposer;
 

diff --git a/SmartContracts/src/interfaces/IPreconfTaskManager.sol b/SmartContracts/src/interfaces/IPreconfTaskManager.sol
@@ -130,7 +130,7 @@ interface IPreconfTaskManager {
     function getLookaheadTail() external view returns (uint256);
 
     /// @dev Returns the entire lookahead buffer
-    function getLookaheadBuffer() external view returns (LookaheadBufferEntry[64] memory);
+    function getLookaheadBuffer() external view returns (LookaheadBufferEntry[128] memory);
 
     /// @dev Returns the lookahead poster for an epoch
     function getLookaheadPoster(uint256 epochTimestamp) external view returns (address);

diff --git a/SmartContracts/test/blocks/BlockProposing.t.sol b/SmartContracts/test/blocks/BlockProposing.t.sol
@@ -166,7 +166,7 @@ contract BlockProposing is BlocksFixtures {
         preconfTaskManager.newBlockProposal("Block Params", "Txn List", 1, lookaheadSetParams);
 
         // Verify that the lookahead for the next epoch has been updated
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
 
         // Check the first entry
         vm.assertEq(lookaheadBuffer[3].preconfer, addr_1);

diff --git a/SmartContracts/test/lookahead/IncorrectLookahead.t.sol b/SmartContracts/test/lookahead/IncorrectLookahead.t.sol
@@ -277,7 +277,7 @@ contract IncorrectLookahead is LookaheadFixtures {
             nextEpochStart + PreconfConstants.SECONDS_IN_EPOCH - PreconfConstants.SECONDS_IN_SLOT;
 
         // Verify that the lookahead has the fallback preconfer
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[3].preconfer, addr_4);
         vm.assertEq(lookaheadBuffer[3].timestamp, lastSlotTimestamp);
         vm.assertEq(lookaheadBuffer[3].prevTimestamp, nextEpochStart - PreconfConstants.SECONDS_IN_SLOT);
@@ -343,7 +343,7 @@ contract IncorrectLookahead is LookaheadFixtures {
             nextEpochStart + PreconfConstants.SECONDS_IN_EPOCH - PreconfConstants.SECONDS_IN_SLOT;
 
         // Verify that the lookahead has the fallback preconfer
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[3].preconfer, addr_4);
         vm.assertEq(lookaheadBuffer[3].timestamp, lastSlotTimestamp);
         vm.assertEq(lookaheadBuffer[3].prevTimestamp, nextEpochStart - PreconfConstants.SECONDS_IN_SLOT);

diff --git a/SmartContracts/test/lookahead/LookaheadPosting.t.sol b/SmartContracts/test/lookahead/LookaheadPosting.t.sol
@@ -34,7 +34,7 @@ contract LookaheadPosting is LookaheadFixtures {
         uint256 lookaheadTail = preconfTaskManager.getLookaheadTail();
         vm.assertEq(lookaheadTail, 1);
 
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[1].preconfer, addr_1);
         vm.assertEq(lookaheadBuffer[1].timestamp, nextEpochStart);
         vm.assertEq(lookaheadBuffer[1].prevTimestamp, 0);
@@ -69,7 +69,7 @@ contract LookaheadPosting is LookaheadFixtures {
         uint256 lookaheadTail = preconfTaskManager.getLookaheadTail();
         vm.assertEq(lookaheadTail, 2);
 
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[1].preconfer, addr_1);
         vm.assertEq(lookaheadBuffer[1].timestamp, nextEpochStart);
         vm.assertEq(lookaheadBuffer[1].prevTimestamp, 0);
@@ -112,7 +112,7 @@ contract LookaheadPosting is LookaheadFixtures {
         uint256 lookaheadTail = preconfTaskManager.getLookaheadTail();
         vm.assertEq(lookaheadTail, 3);
 
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[1].preconfer, addr_1);
         vm.assertEq(lookaheadBuffer[1].timestamp, nextEpochStart);
         vm.assertEq(lookaheadBuffer[1].prevTimestamp, 0);
@@ -161,7 +161,7 @@ contract LookaheadPosting is LookaheadFixtures {
         vm.assertEq(lookaheadTail, 1);
 
         // Verify that addr_4 is inserted as fallback preconfer in lookahead buffer
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[1].preconfer, addr_4);
         vm.assertEq(lookaheadBuffer[1].timestamp, lastSlotTimestampInNextEpoch);
         vm.assertEq(lookaheadBuffer[1].prevTimestamp, 0);
@@ -201,7 +201,7 @@ contract LookaheadPosting is LookaheadFixtures {
         vm.assertEq(lookaheadTail, 1);
 
         // Verify that addr_4 is inserted as fallback preconfer in lookahead buffer
-        IPreconfTaskManager.LookaheadBufferEntry[64] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
+        IPreconfTaskManager.LookaheadBufferEntry[128] memory lookaheadBuffer = preconfTaskManager.getLookaheadBuffer();
         vm.assertEq(lookaheadBuffer[1].preconfer, addr_4);
         vm.assertEq(lookaheadBuffer[1].timestamp, lastSlotTimestampInNextEpoch);
         vm.assertEq(lookaheadBuffer[1].prevTimestamp, 0);