Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e devnet #143

Merged
merged 43 commits into from
Sep 28, 2024
Merged

E2e devnet #143

merged 43 commits into from
Sep 28, 2024

Conversation

mskrzypkows
Copy link
Collaborator

No description provided.

nmjustinchan and others added 30 commits September 18, 2024 14:00
@mskrzypkows mskrzypkows marked this pull request as ready for review September 25, 2024 13:40
avs-deploy Outdated
RUN chmod +x scripts/deployment/*.sh

# Set environment variables
ENV PRIVATE_KEY=0xbcdf20249abf0ed6d944c0288fad489e33f66b3960d9e6229c1cd214ed3bbe31
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmjustinchan Can we have these values read from .env file, so we won't commit them to the repo?

@@ -1,13 +1,13 @@
set -e

export PRIVATE_KEY=0xbcdf20249abf0ed6d944c0288fad489e33f66b3960d9e6229c1cd214ed3bbe31
export FORK_URL=
export FORK_URL="http://139.162.249.67:32002"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmjustinchan The url also would be good to read from .env

@@ -1,7 +1,7 @@
set -e

export PRIVATE_KEY=0xbcdf20249abf0ed6d944c0288fad489e33f66b3960d9e6229c1cd214ed3bbe31
export FORK_URL=
export FORK_URL="http://139.162.249.67:32002"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@mskrzypkows mskrzypkows merged commit e88f399 into master Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants