Address all the comments

NethermindEth · Jan 13, 2025 · 91a712a · 91a712a
1 parent 31aeeed
commit 91a712a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/pkg/hintrunner/core/hint.go b/pkg/hintrunner/core/hint.go
@@ -1235,7 +1235,6 @@ func (hint *InitSquashData) String() string {
 }
 
 func (hint *InitSquashData) Execute(vm *VM.VirtualMachine, ctx *hinter.HintRunnerContext) error {
-	// todo(rodro): Don't know if it could be called multiple times, or
 	err := hinter.InitializeSquashedDictionaryManager(ctx)
 	if err != nil {
 		ctx.SquashedDictionaryManager = hinter.SquashedDictionaryManager{}

diff --git a/pkg/runner/gas.go b/pkg/runner/gas.go
@@ -50,7 +50,7 @@ func gasInitialization(memory *mem.Memory) error {
 	if err != nil {
 		return err
 	}
-
+	// The order of the tokens is relevant, source: https://github.com/starkware-libs/cairo/blob/f6aaaa306804257bfc15d65b5ab6b90e141b54ec/crates/cairo-lang-sierra/src/extensions/modules/gas.rs#L194
 	preCostTokenTypes := []TokenGasCost{PedersenToken, PoseidonToken, BitwiseToken, EcOpToken, AddModToken, MulModToken}
 
 	for _, token := range preCostTokenTypes {

diff --git a/pkg/vm/builtins/builtin_runner.go b/pkg/vm/builtins/builtin_runner.go
@@ -25,7 +25,6 @@ const (
 	AddModeType
 	MulModType
 	GasBuiltinType
-	SystemType
 )
 
 func Runner(name BuiltinType) memory.BuiltinRunner {