feat: uint512 div mod #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-pino
reviewed
Nov 4, 2023
greged93
force-pushed
the
feat/uint512-div-mod
branch
2 times, most recently
from
8e33778 to
ecb8eb4
Compare
rodrigo-pino
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Hey @greged93, great work, thanks for your contribution! Left some comments but they are mostly nitpicks
greged93
force-pushed
the
feat/uint512-div-mod
branch
from
ecb8eb4 to
aa6ee36
Compare
|
Could you add a benchmark test as well, that would be in the dedicated |
greged93
force-pushed
the
feat/uint512-div-mod
branch
from
20afb5b to
9f47b89
Compare
rodrigo-pino
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the uint512 div mod uint256 hint for the hint runner. Resolves #112.