Implement ModBuiltin #666
Merged
Implement ModBuiltin #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicr99
reviewed
Sep 26, 2024
|
There are conflicts after merging #662 that need to be fixed. This PR creates variables for the name of the builtins and replace all places in the code where the raw string is used with such variables. You'll have to do the same for the new builtin. Also there were some refactors done in the code that affect your branch |
cicr99
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer : https://github.dev/lambdaclass/cairo-vm/blob/main/vm/src/vm/runners/builtin_runner/modulo.rs
Fixes: #632
Fixes: #634
Fixes: #635