fix(scan): handle an error on stopping a scan (#81)

closes #80
NeuraLegion · May 11, 2022 · f770070 · f770070
1 parent 4656d99
commit f770070
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/packages/scan/src/Scan.spec.ts b/packages/scan/src/Scan.spec.ts
@@ -261,5 +261,16 @@ describe('Scan', () => {
 
       verify(mockedScans.stopScan(id)).never();
     });
+
+    it('should handle and ignore an error', async () => {
+      when(mockedScans.stopScan(id)).thenReject(
+        new Error(
+          'Is not possible to change the scan status from done to stopped.'
+        )
+      );
+      when(mockedScans.getScan(id)).thenResolve({ status: ScanStatus.DONE });
+
+      await expect(scan.stop()).resolves.not.toThrow();
+    });
   });
 });
diff --git a/packages/scan/src/Scan.ts b/packages/scan/src/Scan.ts
@@ -106,10 +106,14 @@ export class Scan {
   }
 
   public async stop(): Promise<void> {
-    await this.refreshState();
+    try {
+      await this.refreshState();
 
-    if (this.active) {
-      return this.scans.stopScan(this.id);
+      if (this.active) {
+        await this.scans.stopScan(this.id);
+      }
+    } catch {
+      // noop
     }
   }