Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Critical level to the Severity enum #149

Closed
ostridm opened this issue Feb 8, 2023 · 0 comments · Fixed by #150
Closed

Add Critical level to the Severity enum #149

ostridm opened this issue Feb 8, 2023 · 0 comments · Fixed by #150
Assignees
@ostridm
Labels
Type: enhancement New feature or request.

Comments

@ostridm
Copy link
Contributor

ostridm commented Feb 8, 2023 •
edited by derevnjuk
Loading

Description

Add a Critical level to the Severity enum and adjust threshold-related calculations accordingly with Critical as the highest level.

Example

scan.Threshold(Severity.Critical);

Expected Outcome

The scan should continue even if issues with a severity lower than Critical are found and should only stop for issues with Critical severity.
@ostridm ostridm added the Type: enhancement New feature or request. label Feb 8, 2023
@ostridm ostridm self-assigned this Feb 8, 2023
ostridm added a commit that referenced this issue Feb 8, 2023
@ostridm
feat(issue): extend Serverity enum with Crtitical level
f0372fa 
closes #149
@ostridm ostridm mentioned this issue Feb 8, 2023
Merged
ostridm added a commit that referenced this issue Feb 8, 2023
@ostridm
feat(issue): extend Serverity enum with Crtitical level
5bb48f6 
closes #149
ostridm added a commit that referenced this issue Feb 8, 2023
@ostridm
feat(issue): extend Severity enum with Critical level
f12e292 
closes #149
@derevnjuk derevnjuk changed the title Able to define Critical severity threshold Add Critical level to the Severity enum Feb 8, 2023
derevnjuk pushed a commit that referenced this issue Feb 8, 2023
@ostridm
feat(scan): add a critical level to the severity (#150)
5c61e83 
Introduce the ability to set the severity threshold to the `Critical`
level using the `Threshold` method:

```csharp
scan.Threshold(Severity.Critical);
```

With this implementation, the scan will continue despite the presence of
issues with a severity lower than `Critical`, and will only stop for
issues of `Critical` severity.

closes #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ostridm ostridm

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(scan): add a critical level to the severity NeuraLegion/sectester-net
1 participant
@ostridm