Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): add a critical level to the severity #150

Merged

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Feb 8, 2023

Introduce the ability to set the severity threshold to the Critical level using the Threshold method:

scan.Threshold(Severity.Critical);

With this implementation, the scan will continue despite the presence of issues with a severity lower than Critical, and will only stop for issues of Critical severity.

closes #149

@ostridm ostridm added the Type: enhancement New feature or request. label Feb 8, 2023
@ostridm ostridm self-assigned this Feb 8, 2023
@ostridm ostridm force-pushed the feat-#149/able-to-define-critical-severity-threshold branch from f0372fa to 5bb48f6 Compare February 8, 2023 12:33
@ostridm ostridm changed the title feat(issue): extend Serverity enum with Crtitical level feat(issue): extend Serverity enum with Critical level Feb 8, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 8, 2023

Code Climate has analyzed commit f12e292 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.1%.

View more on Code Climate.

@ostridm ostridm force-pushed the feat-#149/able-to-define-critical-severity-threshold branch from 5bb48f6 to f12e292 Compare February 8, 2023 12:36
@ostridm ostridm changed the title feat(issue): extend Serverity enum with Critical level feat(issue): extend Severity enum with Critical level Feb 8, 2023
@ostridm ostridm requested a review from derevnjuk February 8, 2023 15:25
@derevnjuk derevnjuk marked this pull request as ready for review February 8, 2023 19:01
@derevnjuk derevnjuk changed the title feat(issue): extend Severity enum with Critical level feat(scan): add a critical level to the severity Feb 8, 2023
@derevnjuk derevnjuk merged commit 5c61e83 into master Feb 8, 2023
@derevnjuk derevnjuk deleted the feat-#149/able-to-define-critical-severity-threshold branch February 8, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Critical level to the Severity enum
2 participants