Ensuring at least one <spikeThresh> on all <membraneProperties> elements

NeuroML · Apr 18, 2024 · 16a1310 · 16a1310
1 parent 80629aa
commit 16a1310
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/examples/NML2_FullCell.nml b/examples/NML2_FullCell.nml
@@ -88,6 +88,8 @@
 
                 <channelDensity id="naChansSoma" ionChannel="NaConductance" segmentGroup="soma_group" condDensity="120.0 mS_per_cm2" erev="50mV" ion="na"/>
 
+                <spikeThresh value="0mV"/>
+
                 <specificCapacitance segmentGroup="soma_group" value="1.0 uF_per_cm2"/>
 
                 <specificCapacitance segmentGroup="dendrite_group" value="2.0 uF_per_cm2"/>

diff --git a/examples/NML2_FullNeuroML.nml b/examples/NML2_FullNeuroML.nml
@@ -9,9 +9,8 @@
 <!-- Example containing a range of different elements from NeuroML 2 -->
 
 
-
 <!--++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-->
-<!-- Strucure of cell neurites -->
+<!-- Structure of cell neurites -->
 
     <morphology id="NeuroMorpho_PyrCell123">  <!-- see FullCell.xml for more details -->
 
@@ -63,20 +62,14 @@
                             ion="na"
                             erev="50mV"/>  <!-- Temporarily specifying erev in the channelDensity element-->
 
-            <!-- Ions present inside the cell. Note: a fixed reversal potential is specified here  
-            <reversalPotential species="na" value="50mV"/>
-            <reversalPotential species="k" value="-77mV"/>-->
+            <spikeThresh value="0mV"/>
 
-            <!-- more needed -->
         </membraneProperties>
 
         <intracellularProperties>  <!-- used for bioelectrical properties inside a cell -->
 
             <resistivity value="0.1 kohm_cm"/>  <!-- Used for specific axial resistance -->
 
-            <!-- REMOVED UNTIL WE CHECK HOW THE USAGE OF LEMS IMPACTS THIS...
-            <biochemistry reactionScheme="InternalCaDynamics"/>  Ref to earlier pathway -->
-
         </intracellularProperties>
 
     </biophysicalProperties>

diff --git a/examples/NML2_InhomogeneousParams.nml b/examples/NML2_InhomogeneousParams.nml
@@ -71,6 +71,8 @@
                     </variableParameter>
                 </channelDensityNonUniform>
 
+                <spikeThresh value="0mV"/>
+
                 <specificCapacitance segmentGroup="soma_group" value="1.0 uF_per_cm2"/>
             </membraneProperties>