Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for customised file uploads #146

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SMBuilt
Copy link
Contributor

@SMBuilt SMBuilt commented Aug 31, 2021

Added props to allow for customizing file uploads to allow for more than just audio.

Added props are optional to allow for backwards compatibility with existing sermon uploads.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2021

🦋 Changeset detected

Latest commit: eb3a38f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@newfrontdoor/s3-file-upload Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@BarryThePenguin BarryThePenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory you should now be able to..

import { useS3Dropzone } from '@newfrontdoor/s3-file-upload'

..and do something similar to what the <S3Dropzone /> component does, using the isLoading, isError etc state to show different UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants